From 68273a72590350513f0bd37b15d7c5b225e42e66 Mon Sep 17 00:00:00 2001
From: Dominik Polakovics <dominik.polakovics@cloonar.com>
Date: Sun, 25 Jan 2026 14:41:04 +0100
Subject: [PATCH] fix: grafana alerts

---
 hosts/nas/modules/disk-monitoring.nix              |  2 --
 .../grafana/alerting/storage/raid_alerts.nix       |  6 +++---
 .../grafana/alerting/storage/smart_alerts.nix      | 14 +++++++-------
 hosts/web-arm/modules/grafana/default.nix          |  2 --
 4 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/hosts/nas/modules/disk-monitoring.nix b/hosts/nas/modules/disk-monitoring.nix
index a4cb579..af23ce0 100644
--- a/hosts/nas/modules/disk-monitoring.nix
+++ b/hosts/nas/modules/disk-monitoring.nix
@@ -7,8 +7,6 @@
 let
   # Disk identifiers from hardware-configuration.nix
   disks = [
-    "/dev/disk/by-id/ata-ST18000NM000J-2TV103_ZR52TBSB"
-    "/dev/disk/by-id/ata-ST18000NM000J-2TV103_ZR52V9QX"
     "/dev/disk/by-id/ata-TOSHIBA_MG10ACA20TE_8582A01SF4MJ"
     "/dev/disk/by-id/ata-TOSHIBA_MG10ACA20TE_75V2A0H3F4MJ"
     "/dev/disk/by-id/nvme-KIOXIA-EXCERIA_PLUS_G3_SSD_7FJKS1MAZ0E7"
diff --git a/hosts/web-arm/modules/grafana/alerting/storage/raid_alerts.nix b/hosts/web-arm/modules/grafana/alerting/storage/raid_alerts.nix
index 82ad73e..0fbe8dd 100644
--- a/hosts/web-arm/modules/grafana/alerting/storage/raid_alerts.nix
+++ b/hosts/web-arm/modules/grafana/alerting/storage/raid_alerts.nix
@@ -12,7 +12,7 @@
           datasourceUid = "vm-datasource-uid";
           relativeTimeRange = { from = 300; to = 0; };
           model = {
-            expr = ''mdadm_array_state == 0'';
+            expr = ''mdadm_array_state < 1'';
             instant = false;
           };
         }
@@ -35,7 +35,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "RAID array {{ $labels.array }} is degraded";
@@ -84,7 +84,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "RAID array {{ $labels.array }} has missing devices";
diff --git a/hosts/web-arm/modules/grafana/alerting/storage/smart_alerts.nix b/hosts/web-arm/modules/grafana/alerting/storage/smart_alerts.nix
index dd36462..42e9fd6 100644
--- a/hosts/web-arm/modules/grafana/alerting/storage/smart_alerts.nix
+++ b/hosts/web-arm/modules/grafana/alerting/storage/smart_alerts.nix
@@ -12,7 +12,7 @@
           datasourceUid = "vm-datasource-uid";
           relativeTimeRange = { from = 300; to = 0; };
           model = {
-            expr = ''smart_health_passed == 0'';
+            expr = ''smart_health_passed < 1'';
             instant = false;
           };
         }
@@ -35,7 +35,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "S.M.A.R.T. health check FAILED on {{ $labels.device }}";
@@ -84,7 +84,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "Reallocated sectors detected on {{ $labels.device }}";
@@ -133,7 +133,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "Pending sectors detected on {{ $labels.device }}";
@@ -182,7 +182,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "Offline uncorrectable errors on {{ $labels.device }}";
@@ -231,7 +231,7 @@
         }
       ];
       for = "10m";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "High temperature on {{ $labels.device }}";
@@ -280,7 +280,7 @@
         }
       ];
       for = "0s";
-      noDataState = "NoData";
+      noDataState = "OK";
       execErrState = "Error";
       annotations = {
         summary = "UDMA CRC errors on {{ $labels.device }}";
diff --git a/hosts/web-arm/modules/grafana/default.nix b/hosts/web-arm/modules/grafana/default.nix
index f4e0ce2..68576bb 100644
--- a/hosts/web-arm/modules/grafana/default.nix
+++ b/hosts/web-arm/modules/grafana/default.nix
@@ -115,7 +115,6 @@ in
                   settings = {
                     apiToken = "\${PUSHOVER_API_TOKEN}";
                     userKey = "\${PUSHOVER_USER_KEY}";
-                    device = "iphone";
                     priority = 2;
                     retry = "30s";
                     expire = "2m";
@@ -134,7 +133,6 @@ in
                   settings = {
                     apiToken = "\${PUSHOVER_API_TOKEN}";
                     userKey = "\${PUSHOVER_USER_KEY}";
-                    device = "iphone";
                     priority = 1;
                     sound = "siren";
                     okSound = "magic";