daily notes 2026-02-21

This commit is contained in:
Hoid 2026-02-22 03:09:56 +00:00
parent ad88e2fcca
commit 4e3143658f
5 changed files with 145 additions and 17 deletions

View file

@ -879,3 +879,24 @@ Container restart appears to have been clean. All services came back online prop
- **Impact:** Production deploys with old code despite new tag
- **Fix:** Use commit SHA image from staging build instead of `latest`, with retry if not yet available
- **Status:** ✅ FIXED — promote.yml now uses commit SHA with 10-min retry loop
## BUG-083: Copy button on API key recovery broken — CSP blocks inline onclick
- **Date:** 2026-02-21
- **Severity:** HIGH
- **Issue:** The Copy button in the API key recovery success modal uses `onclick="copyRecoveredKey()"` inline handler, but CSP header has `script-src 'self'` which blocks all inline scripts/handlers.
- **Impact:** Users who recover their API key cannot copy it using the Copy button. They must manually select and copy the key text.
- **Fix:** Remove inline onclick, add addEventListener in app.js instead.
- **Status:** ✅ FIXED — commit 4aeac95. All inline onclick handlers replaced with external JS (copy-helper.js for server-rendered pages, addEventListener in app.js for templates).
## BUG-084: Dual HTML build system — templates/ changes don't deploy
- **Date:** 2026-02-21
- **Severity:** HIGH (process issue)
- **Issue:** Project has two build systems:
1. `npm run build:pages` — builds from `templates/pages/``public/`
2. `scripts/build-html.cjs` (Dockerfile) — builds from `public/src/` + `public/partials/``public/`
The Docker build runs last and overwrites. Changes to `templates/pages/` never reach production.
- **Impact:** Session 73 fixes (FAQ schema, h2 heading) were applied to wrong source files and never deployed despite being committed.
- **Root cause:** Build system confusion — two different templating approaches coexist
- **Fix needed (immediate):** Apply fixes to `public/src/index.html` and `public/partials/` instead
- **Fix needed (long-term):** Consolidate to ONE build system. Either remove `templates/` or remove `public/src/`.
- **Status:** ✅ FIXED (immediate) — commit b476b0b applies all changes to correct source files. Long-term consolidation still needed.