fix: clear PDF_TIMEOUT timers after successful render, fix test unhandled rejections
All checks were successful
Build & Deploy to Staging / Build & Deploy to Staging (push) Successful in 12m59s
All checks were successful
Build & Deploy to Staging / Build & Deploy to Staging (push) Successful in 12m59s
This commit is contained in:
parent
f9caef82e6
commit
4473641ee1
2 changed files with 40 additions and 19 deletions
|
|
@ -218,7 +218,16 @@ describe("browser pool", () => {
|
|||
expect(stats.pdfCount).toBe(1);
|
||||
});
|
||||
|
||||
it("cleans up timeout timer after successful render", async () => {
|
||||
vi.useFakeTimers();
|
||||
await browserModule.initBrowser();
|
||||
await browserModule.renderPdf("<h1>Hello</h1>");
|
||||
expect(vi.getTimerCount()).toBe(0);
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("rejects with PDF_TIMEOUT after 30s", async () => {
|
||||
vi.useFakeTimers();
|
||||
await browserModule.initBrowser();
|
||||
// Make ALL pages' setContent hang so whichever is picked will timeout
|
||||
for (const b of mockBrowsers) {
|
||||
|
|
@ -227,11 +236,13 @@ describe("browser pool", () => {
|
|||
}
|
||||
}
|
||||
|
||||
vi.useFakeTimers();
|
||||
const renderPromise = browserModule.renderPdf("<h1>slow</h1>");
|
||||
const renderResult = renderPromise.catch((e: Error) => e);
|
||||
await vi.advanceTimersByTimeAsync(30_001);
|
||||
|
||||
await expect(renderPromise).rejects.toThrow("PDF_TIMEOUT");
|
||||
const err = await renderResult;
|
||||
expect(err).toBeInstanceOf(Error);
|
||||
expect((err as Error).message).toBe("PDF_TIMEOUT");
|
||||
vi.useRealTimers();
|
||||
});
|
||||
});
|
||||
|
|
@ -322,6 +333,7 @@ describe("browser pool", () => {
|
|||
});
|
||||
|
||||
it("rejects with QUEUE_FULL after 30s timeout when all pages busy", async () => {
|
||||
vi.useFakeTimers();
|
||||
await browserModule.initBrowser();
|
||||
|
||||
// Make all pages hang
|
||||
|
|
@ -331,20 +343,27 @@ describe("browser pool", () => {
|
|||
}
|
||||
}
|
||||
|
||||
// Consume all 4 pages (these will hang)
|
||||
browserModule.renderPdf("<p>1</p>");
|
||||
browserModule.renderPdf("<p>2</p>");
|
||||
browserModule.renderPdf("<p>3</p>");
|
||||
browserModule.renderPdf("<p>4</p>");
|
||||
// Consume all 4 pages (these will hang) — catch their rejections
|
||||
const hanging = [
|
||||
browserModule.renderPdf("<p>1</p>").catch(() => {}),
|
||||
browserModule.renderPdf("<p>2</p>").catch(() => {}),
|
||||
browserModule.renderPdf("<p>3</p>").catch(() => {}),
|
||||
browserModule.renderPdf("<p>4</p>").catch(() => {}),
|
||||
];
|
||||
|
||||
vi.useFakeTimers();
|
||||
// 5th request should queue
|
||||
// 5th request should queue — attach catch immediately to prevent unhandled rejection
|
||||
const queued = browserModule.renderPdf("<p>5</p>");
|
||||
const queuedResult = queued.catch((e: Error) => e);
|
||||
|
||||
// Advance past queue timeout
|
||||
// Advance past all timeouts (queue + PDF_TIMEOUT for hanging renders)
|
||||
await vi.advanceTimersByTimeAsync(30_001);
|
||||
|
||||
await expect(queued).rejects.toThrow("QUEUE_FULL");
|
||||
const err = await queuedResult;
|
||||
expect(err).toBeInstanceOf(Error);
|
||||
expect((err as Error).message).toBe("QUEUE_FULL");
|
||||
|
||||
// Let hanging PDF_TIMEOUT rejections settle
|
||||
await Promise.allSettled(hanging);
|
||||
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue