Cloonar/coding-lab
3
0
Fork 0
Code Issues 23 Pull requests 4 Projects Releases Packages 1 Wiki Activity Actions

Per-provider login session naming: lab-login-<id> with prefix-keyed exclusions #77

New issue
Closed
opened 2026-07-09 21:45:44 +02:00 by dominik.polakovics · 1 comment
dominik.polakovics commented 2026-07-09 21:45:44 +02:00
Owner
Copy link

Context

tmuxx.LoginSession is the single fixed session name "lab-login" (internal/tmuxx/tmuxx.go:44). The session-exclusion sites — cap counting, branch ownership, stop-all (design §4d) — key on equality with that one symbol, so every provider's login flow must reuse the same tmux session name. With a second provider (#2 Codex), concurrent logins collide in one session, and the constraint is invisible until an operator setting up a fresh host trips it.

Decided in provider-seam grill (2026-07-09): per-provider names, prefix-keyed exclusions. Safer to change now, while ONE login flow exists, than after two are live.

Design

  • Login sessions are named lab-login-<providerID> (e.g. lab-login-claude-code).
  • Replace equality checks against tmuxx.LoginSession with one predicate, e.g. tmuxx.IsLoginSession(name string) bool (prefix match on lab-login), used by every exclusion site. Keep the prefix a single const so the predicate and the name derivation cannot drift.
  • The claude-code login flow derives its session name from its provider id; no other behavior change.
  • Bare lab-login (the legacy name) should still satisfy the predicate so a login session left over from an older binary is not orphaned from the exclusions.

Acceptance

  • No remaining equality comparisons against a login-session constant (grep-clean); all exclusion sites go through the predicate.
  • Tests: two fake providers' login sessions coexist; both are excluded from cap counting/stop-all; legacy lab-login still recognized.
  • Claude login flow works unchanged end to end (existing tests keep passing with the derived name).
## Context `tmuxx.LoginSession` is the single fixed session name `"lab-login"` (`internal/tmuxx/tmuxx.go:44`). The session-exclusion sites — cap counting, branch ownership, stop-all (design §4d) — key on equality with that one symbol, so every provider's login flow must reuse the same tmux session name. With a second provider (#2 Codex), concurrent logins collide in one session, and the constraint is invisible until an operator setting up a fresh host trips it. Decided in provider-seam grill (2026-07-09): per-provider names, prefix-keyed exclusions. Safer to change now, while ONE login flow exists, than after two are live. ## Design - Login sessions are named `lab-login-<providerID>` (e.g. `lab-login-claude-code`). - Replace equality checks against `tmuxx.LoginSession` with one predicate, e.g. `tmuxx.IsLoginSession(name string) bool` (prefix match on `lab-login`), used by every exclusion site. Keep the prefix a single const so the predicate and the name derivation cannot drift. - The claude-code login flow derives its session name from its provider id; no other behavior change. - Bare `lab-login` (the legacy name) should still satisfy the predicate so a login session left over from an older binary is not orphaned from the exclusions. ## Acceptance - No remaining equality comparisons against a login-session constant (grep-clean); all exclusion sites go through the predicate. - Tests: two fake providers' login sessions coexist; both are excluded from cap counting/stop-all; legacy `lab-login` still recognized. - Claude login flow works unchanged end to end (existing tests keep passing with the derived name).
dominik.polakovics commented 2026-07-09 22:53:20 +02:00
Author
Owner
Copy link

This was generated by AI while landing a PR.

Landed PR #82 — feat(tmuxx): per-provider login sessions lab-login-<id> — merged to main.

Verdict: PASS. Verification signal relied on: the required ci / native check (run #82) → success (4m55s); not re-run locally. ci-nix correctly skipped (no .nix/flake.lock/go.mod in the diff). No merge conflict with main.

Acceptance criteria (#77) all met:

  • Grep-clean: the old tmuxx.LoginSession symbol is removed; every exclusion site (instance cap-count/StopAll, reconcile ownedBranches/killSessionOnBranch, afk drainZombies, claudecode login) now goes through tmuxx.IsLoginSession.
  • Derivation (LoginSessionName) and predicate (IsLoginSession) share the one LoginSessionPrefix const — cannot drift.
  • Legacy bare lab-login still recognized/excluded; lab-loginx/xlab-login correctly rejected (dash-separator guard, tested).
  • Two providers' login sessions coexist and are excluded across cap counting, StopAll, ownedBranches, Discard, and the zombie drain (tests added).
  • Claude login flow unchanged; existing login tests pass with the derived name.
  • ADR-0034 records the decision (extends ADR-0026).

Issue auto-closed via Closes #77.

> *This was generated by AI while landing a PR.* **Landed PR #82** — `feat(tmuxx): per-provider login sessions lab-login-<id>` — merged to `main`. **Verdict: PASS.** Verification signal relied on: the required `ci / native` check (run #82) → **success (4m55s)**; not re-run locally. `ci-nix` correctly skipped (no `.nix`/`flake.lock`/`go.mod` in the diff). No merge conflict with `main`. Acceptance criteria (#77) all met: - Grep-clean: the old `tmuxx.LoginSession` symbol is removed; every exclusion site (instance cap-count/StopAll, reconcile ownedBranches/killSessionOnBranch, afk drainZombies, claudecode login) now goes through `tmuxx.IsLoginSession`. - Derivation (`LoginSessionName`) and predicate (`IsLoginSession`) share the one `LoginSessionPrefix` const — cannot drift. - Legacy bare `lab-login` still recognized/excluded; `lab-loginx`/`xlab-login` correctly rejected (dash-separator guard, tested). - Two providers' login sessions coexist and are excluded across cap counting, StopAll, ownedBranches, Discard, and the zombie drain (tests added). - Claude login flow unchanged; existing login tests pass with the derived name. - ADR-0034 records the decision (extends ADR-0026). Issue auto-closed via `Closes #77`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
afk/255
afk/251
afk/250
afk/249
afk/247
afk/243
afk/235
afk/195
afk/230
afk/222
afk/218
afk/207
afk/201
afk/198
afk/194
afk/191
afk/176
afk/189
afk/182
afk/185
lab/20260718-0240
afk/165
afk/163
afk/160
afk/126
afk/159
afk/156
afk/151
afk/154
afk/149
afk/145
afk/137
afk/142
afk/140
afk/134
afk/132
No results found.
Labels
Clear labels   
bug
Something is broken

  
chore

   
enhancement
New feature or improvement

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wontfix
Will not be actioned

No labels
bug
chore
enhancement
needs-info
needs-triage
ready-for-agent
ready-for-human
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Cloonar/coding-lab#77
No description provided.